Code Review for 6205

Prepared by: (rpz) on 2015-Sep-30 19:35 -0400 EDT
Workspace:/code/illumos-gate (at 5261ecbbcd2a)
Compare against: master (at adb26135f939)
Summary of changes: 218 lines changed: 3 ins; 15 del; 200 mod; 7848 unchg
Patch of changes: 6205.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mandoc/msec.in

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 1 ins; 0 del; 0 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-build-onbld.mf

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
35 lines changed: 0 ins; 0 del; 35 mod; 203 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/Makefile

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 152 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/Makefile.tools

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 0 del; 3 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/codereview/Makefile

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 0 del; 3 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/codereview/codereview.1onbld (renamed and modified from usr/src/tools/codereview/codereview.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/codesign/Makefile

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
6 lines changed: 0 ins; 0 del; 6 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/codesign/signit.1onbld (renamed and modified from usr/src/tools/codesign/signit.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 1 del; 2 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/codesign/signproto.1onbld (renamed and modified from usr/src/tools/codesign/signproto.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
4 lines changed: 0 ins; 1 del; 3 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/Makefile

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
4 lines changed: 0 ins; 0 del; 4 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/cw.1onbld (renamed and modified from usr/src/tools/cw/cw.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/depcheck/Makefile

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
6 lines changed: 0 ins; 0 del; 6 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/depcheck/get_depend_info.1onbld (renamed and modified from usr/src/tools/depcheck/get_depend_info.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 0 del; 3 mod; 197 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/depcheck/make_pkg_db.1onbld (renamed and modified from usr/src/tools/depcheck/make_pkg_db.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 0 del; 3 mod; 193 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/findunref/Makefile

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 0 del; 3 mod; 52 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/findunref/findunref.1onbld (renamed and modified from usr/src/tools/findunref/findunref.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
6 lines changed: 0 ins; 0 del; 6 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/lintdump/Makefile

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 0 del; 3 mod; 42 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/lintdump/lintdump.1onbld (renamed and modified from usr/src/tools/lintdump/lintdump.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
2 lines changed: 0 ins; 1 del; 1 mod; 324 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ndrgen/Makefile

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
4 lines changed: 0 ins; 0 del; 4 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ndrgen/ndrgen.1onbld (renamed and modified from usr/src/tools/ndrgen/ndrgen.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
2 lines changed: 0 ins; 1 del; 1 mod; 512 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/Install.1onbld (renamed and modified from usr/src/tools/scripts/Install.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 361 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/Makefile

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
47 lines changed: 2 ins; 0 del; 45 mod; 129 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/bringovercheck.1onbld (renamed and modified from usr/src/tools/scripts/bringovercheck.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
7 lines changed: 0 ins; 2 del; 5 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/cddlchk.1onbld (renamed and modified from usr/src/tools/scripts/cddlchk.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/check_rtime.1onbld (renamed and modified from usr/src/tools/scripts/check_rtime.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
4 lines changed: 0 ins; 0 del; 4 mod; 730 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/checkpaths.1onbld (renamed and modified from usr/src/tools/scripts/checkpaths.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
5 lines changed: 0 ins; 1 del; 4 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/cstyle.1onbld (renamed and modified from usr/src/tools/scripts/cstyle.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
2 lines changed: 0 ins; 0 del; 2 mod; 165 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/find_elf.1onbld (renamed and modified from usr/src/tools/scripts/find_elf.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
4 lines changed: 0 ins; 0 del; 4 mod; 221 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/flg.flp.1onbld (renamed and modified from usr/src/tools/scripts/flg.flp.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
4 lines changed: 0 ins; 1 del; 3 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/git-pbchk.1onbld (renamed and modified from usr/src/tools/scripts/git-pbchk.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/hdrchk.1onbld (renamed and modified from usr/src/tools/scripts/hdrchk.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 2 del; 1 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/hgsetup.1onbld (renamed and modified from usr/src/tools/scripts/hgsetup.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/interface_check.1onbld (renamed and modified from usr/src/tools/scripts/interface_check.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
4 lines changed: 0 ins; 0 del; 4 mod; 389 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/interface_cmp.1onbld (renamed and modified from usr/src/tools/scripts/interface_cmp.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
4 lines changed: 0 ins; 0 del; 4 mod; 241 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/jstyle.1onbld (renamed and modified from usr/src/tools/scripts/jstyle.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
5 lines changed: 0 ins; 1 del; 4 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/mapfilechk.1onbld (renamed and modified from usr/src/tools/scripts/mapfilechk.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/nightly.1onbld (renamed and modified from usr/src/tools/scripts/nightly.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 0 del; 3 mod; 560 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/onu.1onbld (renamed and modified from usr/src/tools/scripts/onu.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 189 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/sccscheck.1onbld (renamed and modified from usr/src/tools/scripts/sccscheck.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 2 del; 1 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/webrev.1onbld (renamed and modified from usr/src/tools/scripts/webrev.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
5 lines changed: 0 ins; 0 del; 5 mod; 445 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/which_scm.1onbld (renamed and modified from usr/src/tools/scripts/which_scm.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/ws.1onbld (renamed and modified from usr/src/tools/scripts/ws.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
3 lines changed: 0 ins; 1 del; 2 mod; 441 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/wsdiff.1onbld (renamed and modified from usr/src/tools/scripts/wsdiff.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
8 lines changed: 0 ins; 1 del; 7 mod; 191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/xref.1onbld (renamed and modified from usr/src/tools/scripts/xref.1)
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

6205 onbld manuals should be declared as 1onbld
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Josef Sipek <jeffpc@josefsipek.net>
6 lines changed: 0 ins; 0 del; 6 mod; 161 unchg

This code review page was prepared using /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.